feat(media): add fullscreen keyboard shortcut to React controls#1606
Open
sanilsalvi wants to merge 1 commit intobox:masterfrom
Open
feat(media): add fullscreen keyboard shortcut to React controls#1606sanilsalvi wants to merge 1 commit intobox:masterfrom
sanilsalvi wants to merge 1 commit intobox:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the 'f' keyboard shortcut to toggle fullscreen mode in the React video controls (
handleKeydownReact), matching the existing behavior in the legacy controls (handleKeydown).Changes
fandshift+fkey handlers tohandleKeydownReactinMediaBaseViewer.jsMediaBaseViewer-test.jsBackground
The video player has two keyboard handling paths:
handleKeydown) - already supported 'f' for fullscreenhandleKeydownReact) - was missing this shortcutThis PR brings parity between the two by adding the fullscreen shortcut to the React controls path.
Screencast
Full.Screen.Toggle.mov
Test Plan