Add brew-boxen-cask-install by n0ts · Pull Request #57 · boxen/puppet-brewcask

n0ts · 2017-11-27T17:33:13Z

Hello, brew install Caskroom/versions/google-chrome-canary is not working.
And my custom cask is not installing via puppet-brewcask module.
So I add brew custom install command brew boxen-cask-install <cask>.

Thanks,

jacobbednarz · 2017-11-27T20:20:57Z

lib/puppet/provider/package/brewcask.rb

  def install
+    install_cmd = ['brew']
    if install_options.any?
-      execute ["brew", "install", "Caskroom/cask/#{resource[:name]}", *install_options].flatten, command_opts


I was only looking at why Canary wasn't installing for me last week and completely overlooked this.

jacobbednarz · 2017-11-27T20:22:06Z

lib/puppet/provider/package/brewcask.rb

  end

  def self.current(name)
-    caskdir = Pathname.new "#{caskroom}/#{name}"


This needs to stay as double quotes otherwise it won't be evaluated and interpolated correctly.

jacobbednarz · 2017-11-27T20:22:10Z

lib/puppet/provider/package/brewcask.rb

  end

  def self.new_caskroom
-    @new_caskroom ||= Pathname.new("#{home}/Caskroom")


This needs to stay as double quotes otherwise it won't be evaluated and interpolated correctly.

jacobbednarz · 2017-11-27T20:25:41Z

lib/puppet/provider/package/brewcask.rb

-      execute ["brew", "boxen-install", "Caskroom/cask/#{resource[:name]}"], command_opts
+      install_cmd << 'boxen-cask-install'
    end
+    install_cmd << install_options if install_options.any?


This line should be able to go under the existing if install_options.any? a couple of lines up. Should become something like this and save the extra inline expression:

def install install_cmd = ['brew'] if install_options.any? install_cmd << 'cask install' install_cmd << install_options else install_cmd << 'boxen-cask-install' end install_cmd << resource[:name] execute install_cmd.flatten, command_opts end

jacobbednarz · 2017-11-27T20:29:28Z

README.md

- - `homebrew`, >= 1.10.0
+ - `homebrew` >= 1.10.0

 ## Work in progress


I know this wasn't you but can you delete this section? I don't think it really adds any value or information.

OK, I same as puppuet-homebrew/README

jacobbednarz · 2017-11-28T01:42:41Z

Running this patch locally now to see how we go!

jacobbednarz · 2017-11-28T02:30:24Z

Getting some better (actually installing!) but not great behaviour. It looks like once it's installed a package, the next run fails with this message.

Error: Execution of 'brew boxen-cask-install sysdig-inspect' returned 1: ==> Satisfying dependencies
==> Downloading https://download.sysdig.com/stable/sysdig-inspect/sysdig-inspect-0.2.0-mac.dmg
Already downloaded: /Users/jacob/Library/Caches/Homebrew/Cask/sysdig-inspect--0.2.0.dmg
==> Verifying checksum for Cask sysdig-inspect
==> Installing Cask sysdig-inspect
Error: It seems there is already an App at '/Applications/Sysdig Inspect.app'.
Error: /Stage[main]/Boxen::Personal/Package[sysdig-inspect]/ensure: change from absent to present failed: Execution of 'brew boxen-cask-install sysdig-inspect' returned 1: ==> Satisfying dependencies
==> Downloading https://download.sysdig.com/stable/sysdig-inspect/sysdig-inspect-0.2.0-mac.dmg
Already downloaded: /Users/jacob/Library/Caches/Homebrew/Cask/sysdig-inspect--0.2.0.dmg
==> Verifying checksum for Cask sysdig-inspect
==> Installing Cask sysdig-inspect
Error: It seems there is already an App at '/Applications/Sysdig Inspect.app'.

I think this might be Homebrew though...

n0ts · 2017-11-28T05:40:17Z

@jacobbednarz Thanks for local test!

My local environment manifest is bellow, It's working.

# My manifest
  package { 'sysdig-inspect':
      provider => 'brewcask',
  }

$ boxen --no-pull
...

$ brew cask info sysdig-inspect
sysdig-inspect: 0.2.0
https://github.com/draios/sysdig-inspect
/opt/boxen/homebrew/Caskroom/sysdig-inspect/0.2.0 (68B)
From: https://github.com/caskroom/homebrew-cask/blob/master/Casks/sysdig-inspect.rb
==> Name
Sysdig Inspect
==> Artifacts
Sysdig Inspect.app (App)

Are you manually installing sysdig-inspect application?

n0ts · 2017-11-28T05:41:28Z

spec/unit/provider/package/brewcask_spec.rb

+
+      it 'should return install command' do
+        expect{ @provider.install }.to raise_error(Puppet::ExecutionFailure,
+                                                    /brew boxen-cask-install cask/)


brew command is failed, so I check exception message command name.

jacobbednarz · 2017-11-28T05:46:46Z

Nope, I'm all Boxen hiera configuration. I do occasionally get the following error which might be something underlying in Homebrew that isn't quite working as expected.

Error: /usr/local/Homebrew already exists.
Please remove it manually or uninstall and reinstall Homebrew into a new
location as the migration cannot be done automatically.
==> Migrating HOMEBREW_REPOSITORY (please wait)...
Wrapped exception:
Execution of 'brew update' returned 1: Updated 3 taps (caskroom/cask, caskroom/versions, homebrew/core).

Which is very annoying considering this is a freshly out of the box machine 😞

jacobbednarz · 2017-11-28T06:35:50Z

I've done a bit of wiping/re-Homebrewing here and this all looks good now. Once the specs are 💚 I'm happy to merge.

n0ts · 2017-11-28T07:07:50Z

@jacobbednarz CI is now passed. (I add my GITHUB_API_TOKEN environment) I changed travis os is osx, But osx is too slow CI. I'll fix boxen gem, And travis os revert to linux, Thanks.
https://travis-ci.org/n0ts/puppet-brewcask

n0ts · 2017-11-28T07:27:07Z

@jacobbednarz Could you add GITHUB_API_TOKEN? Master CI is failed..

jacobbednarz · 2017-11-28T21:06:53Z

I don't think we need to change the OS this runs on since the specs aren't doing anything OSX specific - it's just rspec for the puppet classes. I think we hit the rate limiting issue since we were running so many builds yesterday and before I look at adding a GitHub token, I'd like to see how often it comes up because this repository is pretty slow moving.

We aren't running anything OSX specific so let's use the generic Linux agents

jacobbednarz · 2017-11-28T21:10:56Z

I've updated the CI OS options via 3ab67cd so now we've just gotta look at https://travis-ci.org/boxen/puppet-brewcask/builds/308649030#L595

n0ts · 2017-11-28T22:13:58Z

I'll find out brewcask defined type self.home

n0ts · 2017-11-28T22:37:31Z

Facter.value(:homebrew_root) => boxen gem facter facter/boxen.rb => boxen gem Boxen::Config.load => Boxen::Keychain.new config.user => Boxen::Keychain::get => keychain is runnig only macos...

Do use calling facter on CI? 🤔

n0ts · 2017-11-28T23:13:33Z

Could you waiting for merge PR?
I'll fix boxen gem quickly, Thanks.

n0ts · 2017-11-28T23:30:48Z

(ref) boxen/boxen#219

n0ts · 2017-12-18T04:58:46Z

boxen 3.1.1 has been released.
puppet-brewcask use cardboard ref: boxen/cardboard#18

jacobbednarz · 2018-02-08T04:13:01Z

@n0ts are you interested in finishing this one up?

n0ts · 2018-02-08T13:22:31Z

@jacobbednarz Thanks for ping. Could you new release cardboard (inside boxen gem version 3.1.1)?

jacobbednarz · 2018-02-08T21:37:26Z

@n0ts do you mean like boxen/cardboard#19? If that's correct I'll release that.

n0ts · 2018-02-08T21:53:07Z

@jacobbednarz Yes, It's correct.

jacobbednarz · 2018-02-08T22:00:06Z

Done! 2.1.1 is released https://rubygems.org/gems/cardboard/versions/2.1.1

n0ts · 2018-02-20T06:27:20Z

@jacobbednarz Thanks for new cardboard release! CI is passed! Thanks!

n0ts · 2018-02-21T08:40:41Z

@jacobbednarz Could you merge it? I'll send you next pr support 10.13, thanks.

jacobbednarz · 2018-02-25T23:57:48Z

manifests/init.pp

    mode   => '0755',
  }
+
+  homebrew::tap { 'caskroom/cask': }


Is this really required? This seems odd that it's never broke before?

n0ts added 4 commits November 27, 2017 09:20

Add brew-boxen-cask-install

ac7fec7

Add class comment

a7e1432

Merge branch 'master' into topic-brewcask

83593ec

Merge branch 'master' into topic-brewcask

db7ae4c

jacobbednarz reviewed Nov 27, 2017

View reviewed changes

n0ts added 2 commits November 27, 2017 17:33

Fix feedback

fb0828c

Update README

bd4c3d2

Add provider test

b199806

n0ts commented Nov 28, 2017

View reviewed changes

Changed test cask name

039c8bc

CI os change to osx

2d011bc

n0ts force-pushed the topic-brewcask branch from f0d06f8 to 2d011bc Compare November 28, 2017 07:21

Remove OS

3ab67cd

We aren't running anything OSX specific so let's use the generic Linux agents

n0ts force-pushed the topic-brewcask branch from 515b86b to ea0a9aa Compare November 28, 2017 22:16

n0ts force-pushed the topic-brewcask branch from c8f9b83 to 617c9d8 Compare November 28, 2017 22:54

n0ts force-pushed the topic-brewcask branch from 617c9d8 to b6f49dc Compare November 28, 2017 22:57

Fix tests

c549f1c

n0ts force-pushed the topic-brewcask branch from b6f49dc to c549f1c Compare November 28, 2017 23:20

Update Gemfile.lock

58a491c

Update cardboard

f3a0cd8

Add tap caskroom/cask

903a127

jacobbednarz reviewed Feb 25, 2018

View reviewed changes

Conversation

n0ts commented Nov 27, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jacobbednarz commented Nov 28, 2017

Uh oh!

jacobbednarz commented Nov 28, 2017

Uh oh!

n0ts commented Nov 28, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jacobbednarz commented Nov 28, 2017

Uh oh!

jacobbednarz commented Nov 28, 2017

Uh oh!

n0ts commented Nov 28, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

n0ts commented Nov 28, 2017

Uh oh!

jacobbednarz commented Nov 28, 2017

Uh oh!

jacobbednarz commented Nov 28, 2017

Uh oh!

n0ts commented Nov 28, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

n0ts commented Nov 28, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

n0ts commented Nov 28, 2017

Uh oh!

n0ts commented Nov 28, 2017

Uh oh!

n0ts commented Dec 18, 2017

Uh oh!

jacobbednarz commented Feb 8, 2018

Uh oh!

n0ts commented Feb 8, 2018

Uh oh!

jacobbednarz commented Feb 8, 2018

Uh oh!

n0ts commented Feb 8, 2018

Uh oh!

jacobbednarz commented Feb 8, 2018

Uh oh!

n0ts commented Feb 20, 2018

Uh oh!

n0ts commented Feb 21, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

n0ts commented Nov 28, 2017 •

edited

Loading

n0ts commented Nov 28, 2017 •

edited

Loading

n0ts commented Nov 28, 2017 •

edited

Loading