MWPW-176237 M@S Plans merch cards: TITLE field and aria label#3
Open
bozojovicic wants to merge 1 commit intomwpw175674a11yfrom
Open
MWPW-176237 M@S Plans merch cards: TITLE field and aria label#3bozojovicic wants to merge 1 commit intomwpw175674a11yfrom
bozojovicic wants to merge 1 commit intomwpw175674a11yfrom
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
3ch023
reviewed
Jul 17, 2025
| } else { | ||
| const productName = card.querySelector('h3')?.textContent || ''; | ||
| link.setAttribute('aria-label', `${link.textContent}${productName ? ' - ' : ''}${productName}`); | ||
| const ariaLabel = `${link.textContent}${productName ? ' - ' : ''}${productName}`; |
3ch023
approved these changes
Jul 17, 2025
bozojovicic
pushed a commit
that referenced
this pull request
Sep 9, 2025
* MWPW-179531-179764 Brand Concierge - Update Error and Loading Messages * MWPW-179921-179531 Brand Concierge Styling Config (#3) * remove new message border * remove prompt suggestion border
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For links and CTAs in mas cards use aria-label values also for title attributes if link/CTA doesn't already have the title authored in mas studio.
Resolves: MWPW-176237
Test page below. Links/CTA on the last card have the title authored. In first two cards the value of aria-label is used.
Test URLs: