Syncing from upstream OCA/e-commerce (18.0) #885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en no stock available
…ble_formated to show the quantity available
…ite_sale_stock_available When website_sale_stock_available is installed, the grid view is showing different allowed quantities than when we access to the products sheet. With this changes we add compatibility with this module and if stock_available_immediately is installed we will get same value. TT38689
As the value of available_threshold was set by default if some module decrease this default, the test will fail, because the text rendered will be "In stock" instead of "5.000 Units available".
Since the changes introduced in odoo/odoo@a8c73eb we need to pass to the template of the remaining units to the function formatQuantity. So we need to pass the function. The steps to reproduce the error: 1. Edit some product, example Customizable Desk 2. Select the option Show Available Qty and set it to 999999 3. Go to /shop You will see the error
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 18.0 #885 +/- ##
==========================================
+ Coverage 88.81% 88.96% +0.14%
==========================================
Files 171 176 +5
Lines 1985 2029 +44
Branches 135 138 +3
==========================================
+ Hits 1763 1805 +42
- Misses 189 190 +1
- Partials 33 34 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bt_gitbot