Fix remote eval "Not connected" when parameter description is missing#1253
Open
colinbennettbrain wants to merge 1 commit intomainfrom
Open
Fix remote eval "Not connected" when parameter description is missing#1253colinbennettbrain wants to merge 1 commit intomainfrom
colinbennettbrain wants to merge 1 commit intomainfrom
Conversation
When a remote eval parameter doesn't have a `description` field set,
`schema.get("description")` returns `None`, which serializes as `null`
in the JSON response. The frontend Zod schema uses `.optional()` which
accepts `undefined` but rejects `null`, causing silent validation
failures and "Not connected" status.
Fix: Only include `description` and `default` fields in the serialized
output when they have actual values, avoiding `null` serialization.
Fixes Pylon case #10206
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Noneasnullfor missingdescriptionfield, but frontend Zod schema uses.optional()which rejectsnullIn
py/src/braintrust/parameters.py, theparameters_to_json_schema()function was unconditionally includingdescriptionanddefaultfields:When null is received, evaluatorDefinitionsSchema.safeParse() fails, causing the "Not connected" status.
Fix
Only include description and default fields when they have actual values.
Test plan