Conversation
Qard
added
enhancement
Qard
force-pushed
the
stephen/auto-instrumentation
branch
9 times, most recently
from
ddf8d8f to
256806c
Compare
Qard
force-pushed
the
stephen/auto-instrumentation
branch
9 times, most recently
from
e37a8b1 to
c5af6af
Compare
Qard
force-pushed
the
stephen/auto-instrumentation
branch
4 times, most recently
from
0e1ebb5 to
a2e79fe
Compare
Qard
force-pushed
the
stephen/auto-instrumentation
branch
10 times, most recently
from
9988e20 to
be9631d
Compare
Uses orchestrion together with AsyncLocalStorage and diagnostics_channel (or als-browser and dc-browser) to provide fully decoupled instrumentation via definitions and diagnostics_channel consumer plugins. Also supports bundlers including vite, webpack, esbuild, and rollup.
Qard
force-pushed
the
stephen/auto-instrumentation
branch
from
be9631d to
460a7c1
Compare
cpinn
left a comment
cpinn
left a comment
There was a problem hiding this comment.
Haven't made it through all the files yet but these were some of the questions I had while looking over the change. Mainly related to packaging and dependencies and whether this is meant to be a separate package or not.
| * will prepend "orchestrion:ai-sdk:" to these names, resulting in final channel names like: | ||
| * "orchestrion:ai-sdk:generateText" | ||
| */ | ||
| export const aiSDKConfigs: InstrumentationConfig[] = [ |
There was a problem hiding this comment.
Originally had a question about if tool calls were being instrumented but looks like yes after I saw the plugin tests. Is that correct the tool calls will still be traced?
| "@types/nunjucks": "^3.2.6", | ||
| "@vercel/functions": "^1.0.2", | ||
| "ajv": "^8.17.1", | ||
| "als-browser": "^1.0.1", |
There was a problem hiding this comment.
If we split the browser build into its own package like we were planning to, would we need als-browser and dc-browser in the main package?
| clean: true, | ||
| }, | ||
| { | ||
| entry: ["src/instrumentation/index.ts"], |
There was a problem hiding this comment.
What is more common auto instrumentation in the main package or a different package?
2 participants
Uses orchestrion together with AsyncLocalStorage and diagnostics_channel (or als-browser and dc-browser) to provide fully decoupled instrumentation via definitions and diagnostics_channel consumer plugins. Also supports bundlers including vite, webpack, esbuild, and rollup.
So far this just adds the infrastructure for the capturing side of the diagnostics_channel model, and some types for the plugin side, but it's not yet set up to actually enable the plugins yet to transform the events into spans. The model is there though for people to see how it would work.