add google roundtrip#70
Open
knjiang wants to merge 1 commit into01-28-testing_framework_for_transformrequest_responsefrom
Open
add google roundtrip#70knjiang wants to merge 1 commit into01-28-testing_framework_for_transformrequest_responsefrom
knjiang wants to merge 1 commit into01-28-testing_framework_for_transformrequest_responsefrom
Conversation
This was referenced Jan 28, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jan 28, 2026
knjiang
force-pushed
the
add_universal_params_between_completions_responses_and_anthropic
branch
from
52805d2 to
af4a595
Compare
knjiang
force-pushed
the
01-26-add_google_roundtrip
branch
from
1feefc7 to
8288bf4
Compare
knjiang
changed the base branch from
add_universal_params_between_completions_responses_and_anthropic
to
graphite-base/70
knjiang
force-pushed
the
01-26-add_google_roundtrip
branch
from
8288bf4 to
68f389d
Compare
knjiang
changed the base branch from
graphite-base/70
to
01-28-testing_framework_for_transformrequest_response
knjiang
commented
Feb 3, 2026
| @@ -0,0 +1,73 @@ | |||
| use crate::providers::google::generated::{ | |||
Contributor
Author
There was a problem hiding this comment.
start at this file, this is where we grab all the testcases and roundtrip them. this automatically tests google/convert.rs
knjiang
commented
Feb 3, 2026
Comment on lines
+98
to
+99
| encrypted_content: Option<String>, | ||
| #[ts(optional)] |
Contributor
Author
There was a problem hiding this comment.
encrypted_content is used by both anthropic/google so i think it should be a universal type.
knjiang
commented
Feb 3, 2026
| GOOGLE_MODEL, | ||
| } from "../../cases"; | ||
|
|
||
| const GOOGLE_API_BASE = "https://generativelanguage.googleapis.com/v1beta"; |
Contributor
Author
There was a problem hiding this comment.
the genai TS sdk isn't just a stainless sdk where it just wraps openapi.
They do a bunch of transforms in the SDK so I'm using the HTTP API instead since the generated types reflect the HTTP API.
knjiang
force-pushed
the
01-26-add_google_roundtrip
branch
from
68f389d to
1b05794
Compare
knjiang
force-pushed
the
01-26-add_google_roundtrip
branch
from
1b05794 to
a2f07da
Compare
knjiang
force-pushed
the
01-28-testing_framework_for_transformrequest_response
branch
from
d09967b to
13cb50c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds google roundtrip tests for existing google cases in the repository.
Note:
In order to conform the existing cases to the generated schema at https://github.com/braintrustdata/lingua/blob/main/crates/lingua/src/providers/google/generated.rs, we have to update the
capture.tsGoogle executor to use the HTTP API instead ofgenaisdk.