[deflag] Deflagration phase 6 — ENABLE_NEW_URL_SCHEME#8133
Open
[deflag] Deflagration phase 6 — ENABLE_NEW_URL_SCHEME#8133
ENABLE_NEW_URL_SCHEME#8133Conversation
## What
Remove the always-on `ENABLE_NEW_URL_SCHEME` flag. This flag controlled whether the Visual Editor used pathname-based routing (`/app/{driveId}`, `/edit/{driveId}`) or legacy query-parameter routing (`?flow=…&mode=…`). With the flag always true, the pathname scheme was already unconditional.
## Why
The flag is `true` in every TF environment. The old query-parameter URL generation was dead code. Part of [Project Deflagration](./PROJECT_DEFLAGRATION.md).
## Changes
### `packages/types`
- **`deployment-configuration.ts`**: Removed `ENABLE_NEW_URL_SCHEME` from `ClientDeploymentConfiguration` type.
### `packages/unified-server`
- **`flags.ts`**: Removed `ENABLE_NEW_URL_SCHEME` export.
- **`config.ts`**: Removed from config wiring.
### `packages/visual-editor`
- **`urls.ts`**: Removed `enableNewUrlScheme` parameter from `makeUrl()`. Inlined the always-true branch (pathname routing). Removed dead `CLIENT_DEPLOYMENT_CONFIG` import. The old query-param branches for `FLOW` and `MODE` in `makeUrl` are gone; `parseUrl()` still handles both schemes for backward compatibility.
- **Tests**: Updated `urls.test.ts` (removed the false-branch `makeUrl` call from `testSymmetrical`), simplified `router-controller.test.ts` (removed `CLIENT_DEPLOYMENT_CONFIG` import and manual flag toggling in the invalid-flow-ID test).
## Testing
- `npm run build:tsc` all affected packages ✅
- `npm run test -w packages/visual-editor` ✅
- `git grep ENABLE_NEW_URL_SCHEME` returns zero hits (excluding project doc)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove the always-on
ENABLE_NEW_URL_SCHEMEflag. This flag controlled whether the Visual Editor used pathname-based routing (/app/{driveId},/edit/{driveId}) or legacy query-parameter routing (?flow=…&mode=…). With the flag always true, the pathname scheme was already unconditional.Why
The flag is
truein every TF environment. The old query-parameter URL generation was dead code. Part of Project Deflagration.Changes
packages/typesdeployment-configuration.ts: RemovedENABLE_NEW_URL_SCHEMEfromClientDeploymentConfigurationtype.packages/unified-serverflags.ts: RemovedENABLE_NEW_URL_SCHEMEexport.config.ts: Removed from config wiring.packages/visual-editorurls.ts: RemovedenableNewUrlSchemeparameter frommakeUrl(). Inlined the always-true branch (pathname routing). Removed deadCLIENT_DEPLOYMENT_CONFIGimport. The old query-param branches forFLOWandMODEinmakeUrlare gone;parseUrl()still handles both schemes for backward compatibility.urls.test.ts(removed the false-branchmakeUrlcall fromtestSymmetrical), simplifiedrouter-controller.test.ts(removedCLIENT_DEPLOYMENT_CONFIGimport and manual flag toggling in the invalid-flow-ID test).Testing
npm run build:tscall affected packages ✅npm run test -w packages/visual-editor✅git grep ENABLE_NEW_URL_SCHEMEreturns zero hits (excluding project doc)