docs: fix wrong formulation #88
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Koukyosyumei
pushed a commit
to Koukyosyumei/pico
that referenced
this pull request
Dec 22, 2025
* update readme * fix brevis-network#88 - Field Arithmetic Bug in SepticExtension SubAssign Implementation * fix #144 - Silent truncation in verify() causes incomplete proof verification * fix #142 - First chunk having cpu chip is incorrectly checked in convert circuit * fix #124,148,186,215 - Remainder is not range checked correctly in reduceWithMaxBits for koalabear field adjusts the hint for koalabear (2^31 - 2^24 + 1) by constraining the lower 24 bits to 0 when the upper 7 bits are all set, as well as adjusting the corresponding range checks and other constants * fix brevis-network#79 - Scalar multiplication reduces by 2^n instead of the group order r * fix #126 - Malicious prover will generate invalid proofs due to underconstrained REM/REMU operations when divisor is 0 * fix #197 - is_real never checked for boolean inside syscall chip * fix #133,137 - two completeness checks issue * fix #199,200 - Quotient domain is completely controlled by prover * fix #204 - Chip ordering is used to fetch all chips instead of preprocessed ones * fix #206 - No check that the lookup multiplicities do not overflow * fix #137 - completeness checks must be added to every circuit that needs to guarantee the VM execution trace is complete (#844) * fix #219 - op_a_0 is not constrained inside MemoryReadWriteChip * fix #226 - Polynomial evaluations are never observed by recursive verifier * fix #228 - ro[config.log_blowup] is not checked to be zero in recursive verifier * fix #230 - Recursive verifier does not check for overflow of the lookup multiplicities * fix #233 - Recursive verifier does not validate chip used for preprocessed traces * fix brevis-network#69 - Word range check uses unconstrained upper_all_one local variable when field prime is Mersenne31 * fix #108 - Inconsistent Multiplicity Increment in read_ghost_addr * fix brevis-network#78 - wrong sign handling when x == 0 produces non-canonical / out-of-range x = p * fix brevis-network#75 - Missing offset check will cause integer overflow violating ELF specification * fix brevis-network#62 - read_write chip does not enforce constraints on opcode selectors * fix #128 - Malicious verifier will recover private witness values breaking zero-knowledge property * unfix #200 * disable m31 and add a comment explaining why * #124 - fix comment description * #226: update Cargo.lock * #144 - additional input length mismatches * add conditional * modify gnark tool * vm/src/chips/precompiles/edwards/ed_decompress.rs (brevis-network#78) * fix format * fix lint * Add onchain verifier constraints (brevis-network#76) * Add vm_ccs serde * Add template_vk commit constant * Tentative onchain constraint completion * chore: code cleanup * add gnark verify test * fix: save groth16_witness.json --------- Co-authored-by: liuxiaobleach <1241368737@qq.com> * Update gnark docker image version * Update vk_map bins * Update maximal_only shape_config * Update (vm_ccs, vm_pk, vm_vk) url * chore: code fmt --------- Co-authored-by: Alan <alan@brevis.network> Co-authored-by: kaiwei-0 <kaiwei@brevis.network> Co-authored-by: liuxiao <1241368737@qq.com> Co-authored-by: benhuang2025 <ben@brevis.network> Co-authored-by: eason <eason@brevis.network>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed wrong formulation