This repository was archived by the owner on Sep 29, 2020. It is now read-only.
Support working from HTMLImageElements from DOM#23
Open
JamesMaroney wants to merge 1 commit intobrianium:masterfrom
Open
Support working from HTMLImageElements from DOM#23JamesMaroney wants to merge 1 commit intobrianium:masterfrom
JamesMaroney wants to merge 1 commit intobrianium:masterfrom
Conversation
new Image() and document.querySelector('img') will now both pass this test
Owner
|
@JamesMaroney thanks a lot for the pull request! I like this approach, and it definitely makes sense. It's causing a bit of a hiccup in the test suite (probably due to my poly filling of the Maybe its as easy as stubbing in a toString implementation for that polyfill? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
new Image() and document.querySelector('img') will now both pass this test