Skip to content

fix unknown errors + update sdk version + use secure maven proxy for expo #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
antoinerousseau wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix unknown errors + update sdk version + use secure maven proxy for expo #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,7 @@ buildscript {
rootProject.allprojects {
repositories {
maven {
url "http://34.82.5.94:8081/artifactory/libs-release-local"
allowInsecureProtocol = true
url "https://backstage.shotgun.live/maven"
}
}
}
Expand Down Expand Up @@ -88,7 +87,7 @@ repositories {
def kotlin_version = getExtOrDefault("kotlinVersion")

dependencies {
implementation (group: "me.bridgefy", name: "android-sdk", version: "1.2.3", ext: "aar") {
implementation (group: "me.bridgefy", name: "android-sdk", version: "1.2.4", ext: "aar") {
transitive = true
}
// For < 0.71, this will be from the local maven repo
Expand Down
4 changes: 2 additions & 2 deletions android/src/main/java/me/bridgefy/plugin/react_native/BridgefyReactNativeModule.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ class BridgefyReactNativeModule(reactContext: ReactApplicationContext) :
promise.resolve(null)
} catch (error: BridgefyException) {
val map = mapFromBridgefyException(error)
promise.reject(map.getString("code"), map.getString("message"), error)
promise.reject(map.getString("code") ?: "INIT_UNKNOWN_ERROR", map.getString("message") ?: "Unknown error occurred", error)
} catch (e: Exception) {
promise.reject("sessionError", "${e.message ?: e.localizedMessage}", e)
}
Expand Down Expand Up @@ -197,7 +197,7 @@ class BridgefyReactNativeModule(reactContext: ReactApplicationContext) :
)
} catch (error: BridgefyException) {
val map = mapFromBridgefyException(error)
promise.reject(map.getString("code"), map.getString("message"), error)
promise.reject(map.getString("code") ?: "SEND_MESSAGE_UNKNOWN_ERROR", map.getString("message") ?: "Unknown error occurred", error)
} catch (e: Exception) {
promise.reject("sessionError", "${e.message ?: e.localizedMessage}", e)
}
Expand Down