forked from kubernetes/website
-
Notifications
You must be signed in to change notification settings - Fork 0
Foxish fix annotation #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
brightbluejay
wants to merge
214
commits into
release-1.4
Choose a base branch
from
foxish-fix-annotation
base: release-1.4
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure on what the best wording for this should be, but `Node Phase` is no longer populated, and so the docs should say so. @Random-Liu on slack/#sig-node told me that they believed node phase was unused. cc @dawnchen
It seems docs were moved from kubernetes repo and now live in the website repo. I've updated the update-demo docs to work again with actual references.
Conflicts: _layouts/docwithnav.html
Signed-off-by: YuPengZTE <yu.peng36@zte.com.cn>
Signed-off-by: YuPengZTE <yu.peng36@zte.com.cn>
using mispellings https://pypi.python.org/pypi/misspellings
The default GCE configuration uses fluentd-cloud-logging, so it's misleading to tell people about elasticsearch/kibana being in their cluster.
Conflicts: _data/tasks.yml _data/tutorials.yml docs/tasks/access-kubernetes-api/http-proxy-access-api.md docs/tasks/index.md docs/tutorials/index.md
Experiment with redirect_from.
Noted this where the relevance of api group is introduced, and
corrected the reference to what the empty string means ("core" api
group, which is the terminology used in the page that introduces api
group, rather than the old text "default").
The proposal doesn't reflect reality.
Broken link
The old text said that the authorizer is expected to determine group memberships when the authenticator does not. This not true. It is allowed, but not expected --- and none of the standard authorizers do it. I tried composing a brief correct statement about this, but the reviews were mainly aghast that internal details of some non-standard authorizers were being injected into the discussion of authentictors. I decided that the better part of valor is simply to delete the whole topic from here. Besides, it is a conclusion that any reader would normally draw --- since there is no statement forbidding it (nor indeed any indication that there might be a reason to forbid it), any reader would naturally conclude that an authorizer is free to derive additional intermediate information of any sort and in any way it likes.
Update kubectl-overview.md
Avoid 'namespaces "sock-shop" not found' messages when users try the demo
…pace2 Ensure namespace is created first in microservices-demo
Modifies the overview for the Kubernetes Basics tutorial
Add kubeadm reference docs
Clarified the apiGroup identified by empty string
Clarified remark about authorizers determining groups
Add generators section in kubectl conventions
Move kubeadm reference, add a navigation link to it and assignees
…elet-ip-choice Note about workaround for kubernetes#34566
Point init containers to documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New to Git, creating pull request to learn locally. I Hope this is OK and I'm not braking anything