Adds ability to add custom classes when adding a new block via class property in data object#185
Open
alberttoledo wants to merge 1 commit intobrijeshb42:masterfrom
Open
Adds ability to add custom classes when adding a new block via class property in data object#185alberttoledo wants to merge 1 commit intobrijeshb42:masterfrom
alberttoledo wants to merge 1 commit intobrijeshb42:masterfrom
Conversation
alberttoledo
force-pushed
the
master
branch
4 times, most recently
from
0e11d77 to
ac77297
Compare
…property in data object
alberttoledo
force-pushed
the
master
branch
from
ac77297 to
4c55545
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom classes for blocks
Just like passing a
srcto an image block, I would love to be able to add a custom class to a block when creating it.Drawback is to remove the class, we would need to replace it with a new block without that class.
I am using the library for the first time today, and this occurred to me as I needed it myself, but it might be a premature request since I am not very familiar. I thought I would open a PR instead of an issue but if there is a better way to do this, or a good reason not to do it, please let me know.
Thanks for the library!