Open
Conversation
Signed-off-by: Jérémy Audiger <jeremy.audiger@icloud.com>
jaudiger
force-pushed
the
extract-inputs-from-autopack-config
branch
from
5899146 to
8184cc7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors
AutopackConfigto extractinputsfield from the config. It has two advantages:AutopackConfig(which has a longer lifetime here).AutopackInputs::Pathssince we can now borrow the inputs.Other side effect but from an API design view: having the inputs outside of
AutopackConfigmakes more sense since they are both independent, one of side we have the inputs of the function and on the other side we have the parameters.