chore(bake): use collect pattern when possible#415
Closed
Conversation
Signed-off-by: Jérémy Audiger <jeremy.audiger@icloud.com>
…matic Signed-off-by: Jérémy Audiger <jeremy.audiger@icloud.com>
jaudiger
force-pushed
the
extend-pattern-3
branch
from
1ad2b26 to
e1fd303
Compare
kylewlacy
requested changes
Jan 29, 2026
Member
kylewlacy
left a comment
kylewlacy
left a comment
There was a problem hiding this comment.
I feel pretty similar with this as I do about #415. I'm a big fan of iterator chaining, but I think for loops have their place. Generally I don't feel strongly enough in one director or the other to accept/reject a PR purely because it does/doesn't use iterator chaining, but in this case, I lean pretty strongly towards for due to the side effects around .insert()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #413, but around collect pattern.