Implement sphobjinv-textconv and remove CLI implementation section from docs#331
Merged
Implement sphobjinv-textconv and remove CLI implementation section from docs#331
Conversation
The matching revision to .git/config was: [diff "objects_inv"] textconv = sh -c 'sphobjinv co plain "$0" -'
Lots to still be fixed/removed
No subparser name in the params for it to query when we're running textconv
Regular convert stuff not relevant
Also make a short version output for textconf entrypoint. Want 'infile' to show as required in the help, and looks like it's not currently possible to render a multiline version string using the 'version' action; and, treating -v as a normal flag means that the inputs fail to parse when no 'infile' is passed.
No subparser for textconv, so no need for subparser tests
The main entrypoint is no longer the only one defined on the project.
RtD context doesn't have the Git config in place, statically, so we have to provide it with the invocation.
It's an internal interface, we want to discourage people from using it directly in code. Replace the couple of meaningful references to CLI-related constants with automatically-substituted-in current values of those constants
Meaningless at best, and actively confusing at worst. Best to remove it.
bskinn
added
type: enhancement ✨
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sphobjinv-textconventrypointCloses #295. Supersedes #312.