Fix checking if livereload option has been set#6
Open
RolKau wants to merge 1 commit intobstefanescu:masterfrom
Open
Fix checking if livereload option has been set#6RolKau wants to merge 1 commit intobstefanescu:masterfrom
RolKau wants to merge 1 commit intobstefanescu:masterfrom
Conversation
Commit fd74513 removed the `this.` before the check for the livereload member, although that is the one that is set just a couple of lines above. I believe this must have been an editing error, because now the server dies with an error if the livereload options is not set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit fd74513 removed the
this.before the check for the livereload member, although that is the one that is set just a couple of lines above. I believe this must have been an editing error, because now the server dies with an error if the livereload options is not set.