Replace bs58check with @scure/base; add RN crypto #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swap bs58check for a @scure/base-based base58check implementation and add react-native-quick-crypto support for native hashing. Added src/io/base58check.ts and wired base58check exports/imports throughout address, p2pkh and p2sh. Introduced a crypto-hashes abstraction and a native react-native implementation (react-native-quick-crypto) while updating crypto imports to use the new module. Added base64 encoder (toBase64) and exported it, plus a minimal type declaration for react-native-quick-crypto. Adjusted package.json (dependencies/peers) to reflect these changes. Updated numerous tests and typings (null-checks, casts, asserts and signature type fixes) to satisfy stricter type/runtime checks.
Replace many non-null assertion usages (!) with explicit casts, undefined checks, and safer control flow across the codebase to improve TypeScript strictness and runtime safety. Added bounds/undefined guards (e.g. outputs, script bytes, witness data), converted index-based loops to safer iteration in several helpers, and clarified intermediate variables (e.g. firstByte, byte1/byte2, controlBlockFirstByte). Also fixed a few logic issues related to witness/coinbase handling, PSBT/transaction indexing casts, worker transferList buffer handling, and ensured presence of ecc.signSchnorr before calling it. Overall these changes reduce possible undefined accesses and make intent clearer for reviewers and the typechecker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swap bs58check for a @scure/base-based base58check implementation and add react-native-quick-crypto support for native hashing. Added src/io/base58check.ts and wired base58check exports/imports throughout address, p2pkh and p2sh. Introduced a crypto-hashes abstraction and a native react-native implementation (react-native-quick-crypto) while updating crypto imports to use the new module. Added base64 encoder (toBase64) and exported it, plus a minimal type declaration for react-native-quick-crypto. Adjusted package.json (dependencies/peers) to reflect these changes. Updated numerous tests and typings (null-checks, casts, asserts and signature type fixes) to satisfy stricter type/runtime checks.
Description
Type of Change
Checklist
Build & Tests
npm installcompletes without errorsnpm testpasses all testsnpm run browserBuildcompletes without errors (if applicable)Code Quality
Documentation
Security
Bitcoin Specific
Testing
Related Issues
By submitting this PR, I confirm that my contribution is made under the terms of the project's license.