Fix ipv6 validation corner cases #260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkwarren
reviewed
Apr 15, 2025
| return false; | ||
| // this is an error condition, it means we found a string of more than | ||
| // four valid hex digits, which is invalid in ipv6 addresses. | ||
| throw new ParseException("invalid hex", this.index); |
Member
There was a problem hiding this comment.
If we want to use exceptions for control flow here, I'd throw an IllegalStateException here over a ParseException.
Suggested change
| throw new ParseException("invalid hex", this.index); | |
| throw new IllegalStateException("invalid hex"); |
added 2 commits
April 16, 2025 10:33
pkwarren
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports the ipv6 fix from bufbuild/protovalidate-go#215.
For context see the description on the above PR. The summary is that this fixes the validation for some corner cases of IPv6 address validation. Namely: