Remove guava dependency #265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkwarren
commented
Apr 20, 2025
|
|
||
| dependencies { | ||
| annotationProcessor(libs.nullaway) | ||
| api(libs.jspecify) |
Member
Author
There was a problem hiding this comment.
jspecify appears to be the newer long term replacement for javax annotations, so switched to it. Previously we pulled these annotations in through Guava's jsr305 dependency.
| alias(libs.plugins.osdetector) | ||
| } | ||
|
|
||
| // Conformance tests aren't bound by lowest common library version. |
Member
Author
There was a problem hiding this comment.
No reason the tests themselves couldn't target a later version of Java.
| }); | ||
| } | ||
|
|
||
| static boolean bytesContains(byte[] arr, byte[] subArr) { |
Member
Author
There was a problem hiding this comment.
This is the main thing we got from Guava. Immutable types are great but for our usage we didn't require them anywhere. We could always (when upgrading to Java 11) switch to similar types on the List/Map methods.
| } | ||
|
|
||
| @Test | ||
| public void testBytesContains() { |
Member
Author
There was a problem hiding this comment.
We may want some more coverage here in protovalidate, however I wanted to confirm the override worked after swapping out Guava.
rodaine
approved these changes
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.