Skip to content

Fix IPv6 double colon parsing #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smaye81 merged 1 commit into from
Apr 24, 2025
Merged

Fix IPv6 double colon parsing #274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions conformance/expected-failures.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,6 @@ kitchen_sink:
standard_rules/repeated:
- items/in/invalid
- items/not_in/invalid
library/is_ip:
- version/6/invalid/ipv6/7h16_double_colon_1h16
- version/6/invalid/ipv6/7h16_double_colon
- version/6/invalid/ipv6/double_colon_8h16
- version/6/invalid/ipv6/1h16_double_colon_7h16
standard_rules/well_known_types/duration:
- in/invalid
- not in/invalid


6 changes: 5 additions & 1 deletion src/main/java/build/buf/protovalidate/Ipv6.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,11 @@ private boolean addressPart() {
break;
}

return this.doubleColonSeen || this.pieces.size() == 8;
int totalPieces = this.pieces.size();
if (this.doubleColonSeen) {
return totalPieces < 8;
}
return totalPieces == 8;
}

/**
Expand Down