Skip to content

Conversation

@smaye81
Copy link
Contributor

@smaye81 smaye81 commented May 13, 2025

Fixes #285

This fixes the check for field path elements when calculating the toString value for ValidationResult and adds a few tests.

Note that this also changes the value to print Validation OK if there are no violations since it didn't make much sense to print Validation Error: if there are no violations.

Technically this is a breaking change.

@smaye81 smaye81 requested review from a user and pkwarren May 13, 2025 21:31
@smaye81 smaye81 merged commit 45271ab into main May 14, 2025
5 checks passed
@smaye81 smaye81 deleted the sayers/fix_tostring_fieldname branch May 14, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] ValidationResult.toString() has reversed check on if (!violation.toProto().hasField())) to write field

2 participants