Skip to content

Conversation

@pkwarren
Copy link
Member

@pkwarren pkwarren commented Jun 2, 2025

Update the buf.gen.yaml files to filter based on the protoc version, removing a manual step required when updating to newer protoc versions.

Update the buf.gen.yaml files to filter based on the protoc version,
removing a manual step required when updating to newer protoc versions.
@pkwarren pkwarren requested review from rodaine and smaye81 June 2, 2025 16:09
clean: true
plugins:
- remote: buf.build/protocolbuffers/java:v31.1
- remote: buf.build/protocolbuffers/java:$protocJavaPluginVersion
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ tree build/buf-gen-templates
build/buf-gen-templates
├── buf.gen.yaml
└── src
    └── test
        └── resources
            └── proto
                ├── buf.gen.cel.testtypes.yaml
                ├── buf.gen.cel.yaml
                ├── buf.gen.imports.yaml
                └── buf.gen.noimports.yaml
$ cat build/buf-gen-templates/buf.gen.yaml 
version: v2
clean: true
plugins:
  - remote: buf.build/protocolbuffers/java:v31.1
    out: build/generated/sources/bufgen

Copy link
Contributor

@smaye81 smaye81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pkwarren pkwarren merged commit 8342d2c into main Jun 2, 2025
4 checks passed
@pkwarren pkwarren deleted the pkw/filter-buf-gen-yaml branch June 2, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants