Skip to content

Conversation

@bugadani
Copy link
Owner

@bugadani bugadani commented Aug 18, 2021

This PR reimplements DefaultTheme in a bit more flexible way, and allows extending the theme with additional color schemes.

Closes #55 and maybe others

Remaining:

  • CheckBox
  • RadioButton
  • Slider
  • ScrollBar
  • Only define a scrollbar style once (H, V)
  • Define multiple states with the same styling (StateA, StateB { ... })
  • Relax static str requirement in button-like objects
  • Label styles (e.g. Header)
  • Use in examples
  • Move checkbox/radio rendering to theme
  • Add border and display clear color to theme (border as a widget?)
  • showcase the title widget

After impl, decide if helper macros should/could be deduplicated.
Investigate how to allow more color options in RGB color schemes.
Define styles required to close #23 and #36, #37

@bugadani bugadani force-pushed the themes branch 3 times, most recently from 6ae064e to 600bddf Compare August 23, 2021 19:12
@bugadani
Copy link
Owner Author

I'm still not quite happy with where this goes. Ideally, I would like to set a primary and seconday accent color, and the theme should generate all colors necessary. This will probably be the focus of a future PR

@bugadani bugadani force-pushed the themes branch 8 times, most recently from 309db8a to 36909a0 Compare August 28, 2021 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Figure out how to add different color schemes to default theme Create different styles for Label

2 participants