Add --exclude option to filter files during uploads

[joshedney]

Goal

Add support for excluding files from uploads based on pattern matching. This allows users to filter out unwanted files (e.g., development source maps, temporary files, or specific directories) during upload operations without having to manually organize their file structure.

Design

The --exclude option was implemented at three levels:

1. CLI Option Definition - Added Exclude []string field to the Upload struct in pkg/options/options.go, making it available for all upload commands
2. Core Matching Logic - Implemented IsFileExcluded() function in pkg/utils/files.go that supports multiple types of patterns:
   • Wildcard matching using doublestar.Match() for file extensions and patterns (e.g., *.map, *.log)
   • Recursive globbing using ** for deep directory matching (e.g., node_modules/**, **/*.map, **/dist/**)
   • Exact filename matching for specific files (e.g., test.map)
3. Upload Integration - Added exclusion check in ProcessFileRequest() in pkg/server/request.go before files are uploaded

The implementation uses the github.com/bmatcuk/doublestar/v4 library for advanced glob pattern matching, including ** support for recursive directory traversal. This provides powerful and flexible filtering capabilities similar to .gitignore patterns, while maintaining compatibility with various file path formats across platforms.

Pattern Examples

• *.map - Exclude all files ending in .map
• node_modules/** - Exclude all files under node_modules/ directory
• **/node_modules/** - Exclude node_modules/ at any directory level
• **/*.test.js - Exclude all .test.js files anywhere in the tree
• src/**/*.map - Exclude all .map files within the src/ directory tree
• **/temp/** - Exclude all files in any temp/ directory

Changeset

• Added Exclude []string field to Upload struct in pkg/options/options.go
• Implemented IsFileExcluded() function in pkg/utils/files.go with doublestar library
• Added github.com/bmatcuk/doublestar/v4 dependency to go.mod
• Added exclusion check in ProcessFileRequest() in pkg/server/request.go
• Added comprehensive unit tests in test/utils/files_test.go:
  • 15 test cases covering wildcards, exact matches, substrings, ** globbing patterns, and edge cases
• Added integration test in test/upload/js_test.go
• Added BDD feature tests in features/cli/exclude-option.feature with 5 scenarios

Testing

Covered by CI

[tomlongridge]

I wonder if this might be too eager to match. It might be more expected for users to need to give a full path match for cases like node_modules/** and avoid unexpected excluding.

[tomlongridge]

How consistent are the file paths when they are matched? Is it possible to say in the usage whether the exclude patterns should be relative to where the command is run?