Sup 4494/remove bubble tea #607
Draft
+611
−960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding table.go to handle output to a table format (adds dep runewidth to properly scale) Adding pager.go to handle paging Adding color.go to respect NO_COLOR
Slightly reworked metadata here to be able to output the queue cleanly in the table view
- Replaced Bubble Tea bulk stop with fmt progress bar (using shared progress bar helper) - Added ASCII-only output, delaying error printing, with a limit clamp - Removed Bubble Tea import
- Removed all bubble tea deps from internal/agent - Moved the single use functions in view.go internal to just be in view.go itself as they don't need to be exported - Removed internal/agent entirely as it was empty :~)
- Uses output.Table and pager for --output text - Refactored output once through the pager as was trying to write data on the fly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At the moment this is in draft, but in essence it aims to remove bubbletea deps and align text output for table views. It adds a pager as it's one of the same, and adds a progress bar. At the moment, this refactors stop.go entirely, and makes some substantial changes to list and view for the new functionality to be put in place (and bubbletea stripped).
Removed internal/agent as it was no longer required
Adds global --no-pager flag
Will respect NO_COLOR and TERM=dumb
Quite a substantial amount of work to go, but the groundwork is done, it's just a case of blanket changing now
Changes
Testing
go test ./...)go fmt ./...)Disclosures / Credits
Used Claude for the progress bar test and to sanity check no-TTY/NO_COLOR/TERM=dumb behaviour as wasn't 100% based off the docs. Also the occasional minor suggestions for optimisation such as a loop being changed to a min/slice. Have tested all changed loops and validated they still work. Test passes, too.