PIE-3516 part 1: get ready to use CD pipeline#37
Conversation
zhming0
commented
Mar 25, 2025
zhming0
commented
- Slightly revamp the doc on releasing this tool.
- Add CD code for automatic deployment.
| plugins: | ||
| - cluster-secrets#v1.0.0: | ||
| variables: | ||
| TWINE_PASSWORD: test-collector-python-pypi-api-token |
There was a problem hiding this comment.
This pipeline isn't working yet as I am still pending on some plumbing works to get this secret provisioned.
But merging this PR has no harm.
There was a problem hiding this comment.
I will use a follow-up PR to replace this with AWS SSM
| if: build.tag != null | ||
| env: | ||
| # It should be a noop | ||
| TWINE_USERNAME: __token__ |
There was a problem hiding this comment.
I'm not sure what this referring to. Can you explain this bit?
There was a problem hiding this comment.
I think this input is a noop for PyPi. According to: twine upload --help
The username to authenticate to the repository (package index) as. Has no effect on PyPI or TestPyPI. (Can
also be set via TWINE_USERNAME environment variable.)
But I set it anyway to prevent prompt showing up.
I guess I could also use --non-interactive, but it would break UX when we use the script manually. 🤷🏿 so I am not sure which one is better.
There was a problem hiding this comment.
Gotcha! Maybe worth putting that quote in the code as comment?
zhming0
force-pushed
the
ming/pie-3516-part-1
branch
from
d2e48bc to
7a4f930
Compare
2 participants
