Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR addresses PyLint CI failures by fixing line length violations and disabling too-few-public-methods warnings on specific classes. The changes improve code maintainability by extracting environment variable names into constants and refactoring the API class to store configuration during initialization.
- Extracted environment variable names and default API URL into class constants
- Refactored API class to store token and API URL as instance variables during initialization
- Added pylint disable comments for
too-few-public-methodsandtoo-many-instance-attributeswarnings
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/buildkite_test_collector/collector/run_env.py | Added pylint disable comments for code quality warnings |
| src/buildkite_test_collector/collector/api.py | Extracted constants and refactored API class initialization to store configuration |
tommeier
approved these changes
Jul 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyLint was failing in CI on
mainafter my recent changes:I've avoided the long line by pulling out some env var name constants, which is nice anyway.
And I've disabled the very silly
too-few-public-methodswarning on the API and RunEnvBuilder classes. A constructor and one public method should be enough for anyone!