Open
Conversation
…rectory Signed-off-by: Hiroshi Hayakawa <hhiroshell@gmail.com>
2 tasks
Signed-off-by: Hiroshi Hayakawa <hhiroshell@gmail.com>
| id = "com.example.stack" | ||
| build-image = "example/build" | ||
| run-image = "example/run" | ||
| build-image = "docker.io/example/build" |
Member
There was a problem hiding this comment.
Does this image need a registry? I think this may meet your criteria of only being used in the local environment
Contributor
Author
There was a problem hiding this comment.
In my understanding, this image means it is pulled from a remote registry to be used as a build environment, so I thought it should be specified with the registry name.
Member
There was a problem hiding this comment.
This should be okay, the daemon will happily accept some-image and index.docker.io/some-image interchangeably.
Side note, while docker.io/some-image is correct, all of our code will resolve a registry-less image name to index.docker.io/<image> so I think using the fully qualified domain would be clearer.
Signed-off-by: Hiroshi Hayakawa <hhiroshell@gmail.com>
4fc4c20 to
8a4c3a5
Compare
Signed-off-by: Hiroshi Hayakawa <hhiroshell@gmail.com>
Signed-off-by: Hiroshi Hayakawa <hhiroshell@gmail.com>
Signed-off-by: Hiroshi Hayakawa <hhiroshell@gmail.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the buildpacks/pack#1218, specifically the modifications to the documentation.
This PR changes the container image names used in the document to fully qualified names. Currently, I'm adopting the following policies:
registry.example.comfor the hostname andexamplefor the organization name.registry.example.com/example/my-appfor-buildpack-authors/concepts/lifecycle-phases.mdI usedregistry.fakeas hostname. Because the name is already used in other parts of the page including terminal recordings, and it's too time-consuming to fix.docker.io/ubuntu:jammyinstead ofubuntu:jammyAnd I fixed some technical errors like typos found when I read through the documents.