feat: added a mac-address flag to build option, so that user can manually set the MAC-address.#2028
Merged
jjbustamante merged 2 commits intobuildpacks:mainfrom Feb 8, 2024
Merged
Conversation
github-actions
bot
added
the
type/enhancement
…e docker config Signed-off-by: Parthiba-Hazra <parthibahazra@gmail.com> fix failed workflow Signed-off-by: Parthiba-Hazra <parthibahazra@gmail.com>
Parthiba-Hazra
force-pushed
the
MAC-address
branch
from
aee82a8 to
3b1544c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2028 +/- ##
==========================================
+ Coverage 79.64% 79.66% +0.02%
==========================================
Files 176 176
Lines 13220 13231 +11
==========================================
+ Hits 10528 10539 +11
Misses 2022 2022
Partials 670 670
Flags with carried forward coverage won't be shown. Click here to find out more. |
jjbustamante
approved these changes
Feb 8, 2024
Member
|
I am going to revert this PR based on the following:
We will need to wait for the ubuntu runner to update the docker >= 25.0 and we also need to update the windows runner with the same version, Once that is done, I think we can merge again this code + the changes made by @matejvasek and the acceptance test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1779