feat(pack): add support for scaffolding new extensions#2041
Open
sarthaksarthak9 wants to merge 13 commits intobuildpacks:mainfrom
Open
feat(pack): add support for scaffolding new extensions#2041sarthaksarthak9 wants to merge 13 commits intobuildpacks:mainfrom
sarthaksarthak9 wants to merge 13 commits intobuildpacks:mainfrom
Conversation
update support for newExtension
add support for extension new
add support for scaffolding new extensions
enable NewExtension method in MockPackClient
enable support for new extension
enable newextension
add test for newExtension
add new Extension in client
github-actions
bot
added
the
type/enhancement
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2041 +/- ##
==========================================
- Coverage 79.63% 79.30% -0.32%
==========================================
Files 176 177 +1
Lines 13214 13367 +153
==========================================
+ Hits 10522 10600 +78
- Misses 2022 2093 +71
- Partials 670 674 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sarthaksarthak9
changed the title
Member
natalieparellano
left a comment
natalieparellano
left a comment
There was a problem hiding this comment.
@sarthaksarthak9 thank you for this, the PR is progressing nicely. I left a few comments :)
Contributor
Author
thank you for reviewing :) |
remove the stack flag and update the commands
remove the unnecessary indentation
update the unit test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for scaffolding new extensions
Output
Before
After
Documentation
Related
Resolves #1636