Draft
Conversation
Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
sclevine
changed the title
Closed
imjasonh
reviewed
Jul 1, 2021
Signed-off-by: Stephen Levine <stephen.levine@gmail.com> Co-authored-by: Jason Hall <jasonhall@redhat.com>
Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
jabrown85
reviewed
Jul 1, 2021
Signed-off-by: Stephen Levine <stephen.levine@gmail.com> Co-authored-by: Jesse Brown <jabrown85@gmail.com>
jkutner
reviewed
Jul 8, 2021
| # How it Works | ||
| [how-it-works]: #how-it-works | ||
|
|
||
| Builders may specify an ordered list of runtime base images, where each entry may contain a list of runtime base image mirrors. |
Member
There was a problem hiding this comment.
Can we include an example of what this would look like?
[[stacks]]
id = "centos"
build-image = "example/centos7-build:123"
run-image = "example/centos7-run:123"
[[stacks]]
id = "bionic"
build-image = "example/ubuntu-build:123"
run-image = "example/ubuntu-run:123"
jkutner
reviewed
Jul 8, 2021
|
|
||
| Builders may specify an ordered list of runtime base images, where each entry may contain a list of runtime base image mirrors. | ||
|
|
||
| Buildpacks may specify a list of package names (as [PURL URLs](https://github.com/package-url/purl-spec) without versions or qualifiers) in a `packages` table in the build plan during detection. |
Member
There was a problem hiding this comment.
Does this mean that the lifecycle needs to be able to inspect a base image and determine what packages it includes?
Member
Author
There was a problem hiding this comment.
Yep, just like it works with mixins and buildpack.toml today.
Member
There was a problem hiding this comment.
But does this mean it needs to be aware of how to do that on a particular stack (apt, yum, etc)? With mixins it can do this generically.
Member
Author
There was a problem hiding this comment.
The PURL URLs in the CycloneDX-formatted SBoM provide a generic abstraction for this.
jkutner
reviewed
Jul 8, 2021
Signed-off-by: Stephen Levine <stephen.levine@gmail.com> Co-authored-by: Joe Kutner <jpkutner@gmail.com>
This was referenced Jul 21, 2021
nebhale
approved these changes
Jul 21, 2021
Member
Author
|
Putting this on hold for now. #173 currently suggests an alternative implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Readable
This proposal is part of a larger initiative to reduce complexity originally outlined in #167