RFC: Application source files mtime#328
Open
Infra-Red wants to merge 1 commit intobuildpacks:mainfrom
Open
Conversation
Signed-off-by: Andrei Krasnitski <11172501+Infra-Red@users.noreply.github.com>
Member
|
Maintainers, As you review this RFC please queue up issues to be created using the following commands: Issues(none) |
|
|
||
| ### What is the expected outcome? | ||
|
|
||
| Lifecycle will be capable of copying the source files into the application image with original mtime preserved or set to a user-provided value. |
Member
There was a problem hiding this comment.
There is a lifecycle issue here: buildpacks/lifecycle#1358
This comment lists out some subtleties that would be good to address here, such as what should happen if buildpacks modify the source directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Readable
Related to buildpacks/lifecycle#1358