Skip to content

WIP: Trigger build workflow on lifecycle-release dispatch event and update builder.toml lifecycle version#138

Draft
glokta1 wants to merge 2 commits intobuildpacks:mainfrom
glokta1:build-on-lifecycle-release
Draft

WIP: Trigger build workflow on lifecycle-release dispatch event and update builder.toml lifecycle version#138
glokta1 wants to merge 2 commits intobuildpacks:mainfrom
glokta1:build-on-lifecycle-release

Conversation

@glokta1
Copy link

@glokta1 glokta1 commented Feb 14, 2023

Ensures sample builders are up-to-date with the lifecycle. See buildpacks/lifecycle#801

Signed-off-by: glokta1 rafeyahmad@protonmail.com

Will update this PR with the script to update builder.toml files in a bit. I suspect I won't have write permissions to modify files though so I'm a little confused on how to test it...any pointers? 😅. I'm new to testing these workflows

Ensures sample builders are up-to-date with the lifecycle. See buildpacks/lifecycle#801

Signed-off-by: glokta1 <rafeyahmad@protonmail.com>
@glokta1 glokta1 requested a review from a team as a code owner February 14, 2023 19:15
@AidanDelaney
Copy link
Member

I like this idea. I need to get my head around GH triggers before I approve it.

@natalieparellano
Copy link
Member

My suggestions here: buildpacks/lifecycle#801 (comment)

There may be a better way to do it, feedback is welcome :)

Signed-off-by: glokta1 <rafeyahmad@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments