Buildpack api changes to support phase 1 of Dockerfiles implementation#307
Merged
sambhav merged 11 commits intobuildpack/0.9from Aug 23, 2022
Merged
Buildpack api changes to support phase 1 of Dockerfiles implementation#307sambhav merged 11 commits intobuildpack/0.9from
sambhav merged 11 commits intobuildpack/0.9from
Conversation
natalieparellano
force-pushed
the
extensions-buildpack-api
branch
from
012139a to
035fb9c
Compare
natalieparellano
force-pushed
the
extensions-buildpack-api
branch
5 times, most recently
from
6402e7f to
d3a5b3d
Compare
Signed-off-by: Natalie Arellano <narellano@vmware.com>
natalieparellano
force-pushed
the
extensions-buildpack-api
branch
from
d3a5b3d to
9a5955f
Compare
This was referenced Apr 18, 2022
natalieparellano
commented
May 5, 2022
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: BarDweller <bardweller@gmail.com>
42 tasks
cache svgs and set svg bg to white (helps with github darkmode)
jkutner
reviewed
Jun 26, 2022
jkutner
reviewed
Jun 26, 2022
jkutner
reviewed
Jun 26, 2022
jkutner
reviewed
Jun 26, 2022
jkutner
requested changes
Jun 26, 2022
Member
jkutner
left a comment
jkutner
left a comment
There was a problem hiding this comment.
I have a couple small questions about word choice
added 2 commits
June 27, 2022 11:43
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Member
Author
|
Thanks @jkutner! I made some updates based on your feedback. |
jkutner
reviewed
Jun 27, 2022
jkutner
reviewed
Jun 27, 2022
Member
Author
Also make clear that generation is for extensions and build is for buildpacks Signed-off-by: Natalie Arellano <narellano@vmware.com>
natalieparellano
changed the base branch from
buildpack/0.9
to
buildpack-terminology
jkutner
approved these changes
Jun 29, 2022
added 4 commits
July 7, 2022 11:40
A couple other small fixes. Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
sambhav
approved these changes
Aug 22, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would allow extensions to output a Dockerfile that can be used to switch the runtime base image only.
The extension phase is not needed as nothing is applied.
For further context, see this comment.