Add support for default values in Forms4s#19
Open
LSUDOKO wants to merge 1 commit intobusiness4s:mainfrom
Open
Conversation
📝 WalkthroughWalkthroughThis PR adds compile-time default value extraction and propagation throughout the forms4s library. A new macro-based Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
implements support for default values in both Scala-derived forms and JSON Schema-derived forms. It ensures that default values defined in case classes or JSON schemas are correctly used to pre-fill forms on creation
forms4s-jsonschema:
Updated
FormFromJsonSchema.scala
to extract the default value from JSON Schema properties (specifically handling ExampleSingleValue) and pass it to the FormElement core.
Added a new test case in
FormFromJsonSchemaSpec.scala
to verify that default values from a JSON schema are correctly propagated to the generated form elements.
all tests passed
solve issue #8
Summary by CodeRabbit
New Features
Tests
✏️ Tip: You can customize this high-level summary in your review settings.