Implement cartesian tool for projects of getting sets of buttons to game counts#2934
Draft
agathazeren wants to merge 3 commits intobuttonmen-dev:masterfrom
Draft
Implement cartesian tool for projects of getting sets of buttons to game counts#2934agathazeren wants to merge 3 commits intobuttonmen-dev:masterfrom
cartesian tool for projects of getting sets of buttons to game counts#2934agathazeren wants to merge 3 commits intobuttonmen-dev:masterfrom
Conversation
Contributor
|
I reckon this could do with a little bit of commenting so that it's obvious what it does---both for others and for future you. :) |
Author
|
I agree. I'm not sure when I will get this sorted, but I'll try to get to it in not too long. |
Counts the total number of games required to meet the limit value for all included buttons.
Contributor
|
Just noting that the correct way to be bringing in updates into your branch is to rebase your branch instead of merging our changes. This means that your branch becomes relative to our current code status and that we don't have merge issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's left as a draft because i need to eliminate the commenting out of the future imports. (probably either setting up virtualenv and using an older version of python or updating the codebase, but maybe it's something else that I have to research.) It also should be updated to use: #2912 once that lands
Sample run: