-
Notifications
You must be signed in to change notification settings - Fork 45
release: componentize-js v0.18.3-rc.1 #234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
b47402c to
554969b
Compare
|
Hey @tschneidereit so one big change here is that the The reason this was necessary is because right now the CI builds the package that's about to be released into an artifact, and This introduces some room for error when doing manual releases so would appreciate some feedback here -- could certainly be convinced to find another way around this, to keep manual releases as close to foolproof as possible |
|
@vados-cosmonic, hmm, do you think we might be able to do something like set an env var in CI to skip the packaging? Or alternatively do some kind of check for whether an up-to-date package is available when running locally? This otherwise seems like a pretty substantial footgun to me |
|
Yeah so one idea is to keep I agree with the footgun there, gave me lots of pause for sure. If you're OK with introducing the small script I'm very happy to do that instead! |
|
Let's do that, then! |
8b22fde to
4ccdd25
Compare
Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
4ccdd25 to
ebb4e83
Compare
This is a release prep branch for
componentize-jsreleasev0.18.3-rc.1.To ensure this release is ready to be merged:
After this PR is merged tagging, artifact builds and releasing will run automatically.