Skip to content

Conversation

@jco-release-bot
Copy link
Collaborator

@jco-release-bot jco-release-bot commented Jun 30, 2025

This is a release prep branch for componentize-js release v0.18.3-rc.1.

To ensure this release is ready to be merged:

  • Review updated CHANGELOG(s)

After this PR is merged tagging, artifact builds and releasing will run automatically.

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@vados-cosmonic vados-cosmonic force-pushed the prep-release-v0.18.3-rc.1 branch from b47402c to 554969b Compare June 30, 2025 11:58
@vados-cosmonic
Copy link
Contributor

Hey @tschneidereit so one big change here is that the prepack/prepublish script is gone -- this means that if someone tries to make a manual release, they need to remember to do the component build themselves before they run npm publish.

The reason this was necessary is because right now the CI builds the package that's about to be released into an artifact, and npm will run the pack script regardless of the kind of artifact you're releasing, when you run npm publish (so, even if I give it a .tgz to publish it still tries to run the prepublish/prepack scripts which perform a full build). This would have lead to running the build in CI twice (once to build the artifact, then again when trying to actually publish the artifact.

This introduces some room for error when doing manual releases so would appreciate some feedback here -- could certainly be convinced to find another way around this, to keep manual releases as close to foolproof as possible

@tschneidereit
Copy link
Member

@vados-cosmonic, hmm, do you think we might be able to do something like set an env var in CI to skip the packaging? Or alternatively do some kind of check for whether an up-to-date package is available when running locally? This otherwise seems like a pretty substantial footgun to me

@vados-cosmonic
Copy link
Contributor

Yeah so one idea is to keep prepack and have it run a script instead (then we can set an ENV var to override) -- that would definitely make things more controllable, at the cost of introducing a small script.

I agree with the footgun there, gave me lots of pause for sure. If you're OK with introducing the small script I'm very happy to do that instead!

@tschneidereit
Copy link
Member

Let's do that, then!

@vados-cosmonic vados-cosmonic force-pushed the prep-release-v0.18.3-rc.1 branch from 8b22fde to 4ccdd25 Compare June 30, 2025 16:22
Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
@vados-cosmonic vados-cosmonic force-pushed the prep-release-v0.18.3-rc.1 branch from 4ccdd25 to ebb4e83 Compare June 30, 2025 16:38
@vados-cosmonic vados-cosmonic merged commit 73eb294 into main Jun 30, 2025
21 checks passed
@vados-cosmonic vados-cosmonic deleted the prep-release-v0.18.3-rc.1 branch June 30, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants