-
Notifications
You must be signed in to change notification settings - Fork 45
release: componentize-js v0.18.3-rc.2 #236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4d32a35 to
4f769a7
Compare
|
Hey @tschneidereit please note, this PR contains a commit that also fixes a problem with the release here: https://github.com/bytecodealliance/ComponentizeJS/actions/runs/15981111713 The There is also a change in here to improve the |
tschneidereit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes all look good to me, but I would strongly before splitting the functional changes from the release, and never mix the two in the same PR. Would it be possible to land your fixes in a separate PR and rebase this one on that?
|
Those bugs were discovered during the process of the release and the important one is in a separate commit, but I understand the perspective -- I can certainly split those changes out! |
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
4f769a7 to
c987aee
Compare
Co-authored-by: Till Schneidereit <till@tillschneidereit.net>
This is a release prep branch for
componentize-jsreleasev0.18.3-rc.2.To ensure this release is ready to be merged:
After this PR is merged tagging, artifact builds and releasing will run automatically.