Skip to content

Conversation

@jco-release-bot
Copy link
Collaborator

@jco-release-bot jco-release-bot commented Jun 30, 2025

This is a release prep branch for componentize-js release v0.18.3-rc.2.

To ensure this release is ready to be merged:

  • Review updated CHANGELOG(s)

After this PR is merged tagging, artifact builds and releasing will run automatically.

@vados-cosmonic vados-cosmonic force-pushed the prep-release-v0.18.3-rc.2 branch from 4d32a35 to 4f769a7 Compare June 30, 2025 19:20
@vados-cosmonic
Copy link
Contributor

vados-cosmonic commented Jun 30, 2025

Hey @tschneidereit please note, this PR contains a commit that also fixes a problem with the release here: https://github.com/bytecodealliance/ComponentizeJS/actions/runs/15981111713

The .npmrc configuration that would cause the NPM token to be picked up from ENV wasn't in place, so the NPM publish didn't succeed -- this PR fixes that (and an errant space).

There is also a change in here to improve the tag_pattern that identifies version tags as they stand in the repo -- there'there are no distinct commits in between the RCs so nothing shows up, but when 0.18.3 actually gets pushed out, it will be useful.

Copy link
Member

@tschneidereit tschneidereit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes all look good to me, but I would strongly before splitting the functional changes from the release, and never mix the two in the same PR. Would it be possible to land your fixes in a separate PR and rebase this one on that?

@vados-cosmonic
Copy link
Contributor

Those bugs were discovered during the process of the release and the important one is in a separate commit, but I understand the perspective -- I can certainly split those changes out!

@vados-cosmonic vados-cosmonic mentioned this pull request Jul 3, 2025
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@vados-cosmonic vados-cosmonic force-pushed the prep-release-v0.18.3-rc.2 branch from 4f769a7 to c987aee Compare July 4, 2025 11:30
Co-authored-by: Till Schneidereit <till@tillschneidereit.net>
@vados-cosmonic vados-cosmonic merged commit 5640bfe into main Jul 7, 2025
4 checks passed
@vados-cosmonic vados-cosmonic deleted the prep-release-v0.18.3-rc.2 branch July 7, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants