feat(ci): run mdbook on pull requests#226
Merged
itowlson merged 12 commits intobytecodealliance:mainfrom Mar 26, 2025
Merged
Conversation
vados-cosmonic
force-pushed
the
fix(ci)=run-mdbook-on-prs
branch
3 times, most recently
from
b474296 to
4d7fa1f
Compare
Collaborator
Author
|
OK this should be fine now -- added some caching, which should hopefully help things go a bit faster. |
This was referenced Mar 25, 2025
itowlson
reviewed
Mar 25, 2025
Collaborator
itowlson
left a comment
itowlson
left a comment
There was a problem hiding this comment.
This looks like a great improvement, but would you mind dropping some of the comments from the mdbook sample that are a bit "GitHub actions for beginners" please? Thanks!
vados-cosmonic
force-pushed
the
fix(ci)=run-mdbook-on-prs
branch
2 times, most recently
from
84c0624 to
10c31df
Compare
Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
vados-cosmonic
force-pushed
the
fix(ci)=run-mdbook-on-prs
branch
5 times, most recently
from
7b15621 to
b465716
Compare
Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
vados-cosmonic
force-pushed
the
fix(ci)=run-mdbook-on-prs
branch
from
a20adef to
35e4017
Compare
Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
Collaborator
Author
|
Hey @itowlson thisis ready for review! Also checked that deploy works on my own fork :) |
itowlson
approved these changes
Mar 26, 2025
Collaborator
itowlson
left a comment
itowlson
left a comment
There was a problem hiding this comment.
Thanks @vados-cosmonic - I love the structure of the workflows and how you've pulled some of the nitty gritty out to common actions. I'm not very confident with reviewing the Just and Python stuff but I'm happy to 
and keep moving forwards!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was wondering how PRs could have gotten though without
mdbook-linkcheckrunning...Also @itowlson / @kate-goldenring how do ya'll feel about disabling merge-commits in favor of squash/rebase merging?