Small corrections to Javascript section#278
Merged
vados-cosmonic merged 2 commits intobytecodealliance:mainfrom Jul 13, 2025
Merged
Small corrections to Javascript section#278vados-cosmonic merged 2 commits intobytecodealliance:mainfrom
vados-cosmonic merged 2 commits intobytecodealliance:mainfrom
Conversation
in "Running a Component from JavaScript Applications (including the Browser)" section, what is exported from `./dist/transpiled/adder.js` is an `add` object and not a function. You can see this difference in the example application at https://github.com/bytecodealliance/jco/blob/b2e8641d15dbc25a1d68b66451ab670a47a963d5/examples/components/adder/run-transpiled.js
mikemoraned
changed the title
I'm not 100% sure of this, but I think this full `example:string-reverse/reverse.reverse-string` path is meant to break down as: * package: `example:string-reverse` * interface: `reverse` * function name: `reverse-string` If so, then the first part should be `example:string-reverse` and not `example:reverse-string`
mikemoraned
force-pushed
the
july2025-small-corrections
branch
from
d120435 to
c24b5db
Compare
vados-cosmonic
approved these changes
Jul 13, 2025
Collaborator
vados-cosmonic
left a comment
vados-cosmonic
left a comment
There was a problem hiding this comment.
LGTM 🚀
Thanks for fixing this @mikemoraned !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add.add, not justadd, in Node examplereverse-string(See commits for more details)