Revise and reorganize "Why the Component Model?" section#281
Revise and reorganize "Why the Component Model?" section#281vados-cosmonic merged 32 commits intobytecodealliance:mainfrom
Conversation
vados-cosmonic
left a comment
vados-cosmonic
left a comment
There was a problem hiding this comment.
Hey thanks for working on this @catamorphism -- I had a bunch of comments but hopefully they all make sense/happy to go through them synchronously at some point as well!
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
|
I think I've addressed all the review comments now. @vados-cosmonic let me know if I missed anything! |
vados-cosmonic
left a comment
vados-cosmonic
left a comment
There was a problem hiding this comment.
Hey @catamorphism thanks for the fixups -- I took another look through.
I think it's really important to get this right, thanks for the hard work here
lukewagner
left a comment
lukewagner
left a comment
There was a problem hiding this comment.
Great to see the work on continually improving the docs! Just a few drive-by suggestions:
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Co-authored-by: Luke Wagner <mail@lukewagner.name>
Co-authored-by: Luke Wagner <mail@lukewagner.name>
Co-authored-by: Luke Wagner <mail@lukewagner.name>
vados-cosmonic
left a comment
vados-cosmonic
left a comment
There was a problem hiding this comment.
LGTM 🚀
Thanks @catamorphism for the work here -- this is a marked improvement over what we had before!
3 participants
I've tried to revise this section with a Wasm beginner in mind, as well as breaking it up into sections so it's a little easier to skim.
In some cases it was hard to be sure how much detail to go into vs. linking to external sources (e.g. memory), but I tried to strike a balance between not intimidating the reader with too much detail, and not intimidating the reader with undefined terms.
The diffs are a bit hard to follow, so it's probably easiest to review by viewing the rendered Markdown side-by-side with the current version.