Split "Language Agnostic Tooling" into its own page and fix example#282
Merged
vados-cosmonic merged 14 commits intobytecodealliance:mainfrom Jul 18, 2025
Merged
Conversation
catamorphism
force-pushed
the
language-support
branch
from
8170a2d to
d14eb3d
Compare
Collaborator
vados-cosmonic
left a comment
vados-cosmonic
left a comment
There was a problem hiding this comment.
Thanks @catamorphism ! Thanks for splitting this out, this actually just came up in another PR actually.
Resolves #279
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
itowlson
reviewed
Jul 16, 2025
Contributor
Author
|
All the review feedback should be addressed now, unless I missed something. |
vados-cosmonic
approved these changes
Jul 18, 2025
Collaborator
vados-cosmonic
left a comment
vados-cosmonic
left a comment
There was a problem hiding this comment.
LGTM 🚀
Thanks for the awesome work here @catamorphism!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per #279 I split off "Language Agnostic Tooling" into a separate page.
Also, the example didn't work for me (with wasm-tools 1.235.0); the export in the .wat file was wrong and the function name, preceded by a '#', needed to be appended to the export name.
I plan to work more on this page, but I wanted to fix the example now so that no one gets led astray!