Replace instant with datetime in wit-example.md#302
Merged
vados-cosmonic merged 1 commit intobytecodealliance:mainfrom Aug 16, 2025
Merged
Replace instant with datetime in wit-example.md#302vados-cosmonic merged 1 commit intobytecodealliance:mainfrom
vados-cosmonic merged 1 commit intobytecodealliance:mainfrom
Conversation
I would imagine what happened here is that what is currently defined as datetime used to be called instant. It looks like it got renamed in some places, but not everywhere. This patch tries to take care of that. Apologies if I'm messing something up, this is my first pull request ever in this project.
Contributor
|
Thanks for catching this! (I wrote the doc, but am not a reviewer.) |
Contributor
Author
|
No problem. I'm very unfamiliar with the processes to get PRs merged in this project (I'm new to webassembly in general, hence my reading the docs) -- if there's something that I should do / know to help please feel free to refer me to documentation. I looked at the code of conduct and the contributing guidelines but they seem pretty generic for this project. |
Contributor
|
You're doing everything right as far as I can tell! |
vados-cosmonic
approved these changes
Aug 16, 2025
Collaborator
vados-cosmonic
left a comment
vados-cosmonic
left a comment
There was a problem hiding this comment.
LGTM 🚀
Thanks for fixing this @og-syn !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would imagine what happened here is that what is currently defined as datetime used to be called instant. It looks like it got renamed in some places, but not everywhere.
This patch tries to take care of that.
Apologies if I'm messing something up, this is my first pull request ever in this project.