'add' to 'foo' and minor typo in wasmtime.md#303
Merged
vados-cosmonic merged 2 commits intobytecodealliance:mainfrom Aug 16, 2025
Merged
'add' to 'foo' and minor typo in wasmtime.md#303vados-cosmonic merged 2 commits intobytecodealliance:mainfrom
vados-cosmonic merged 2 commits intobytecodealliance:mainfrom
Conversation
This fixes an example which uses 'add' but where the surrounding text uses 'foo' as a function name. Foo seems more thematic.
There's also a minor typo ('and' is misspelled AFAICT).
Collaborator
vados-cosmonic
left a comment
vados-cosmonic
left a comment
There was a problem hiding this comment.
Thanks for fixing the typo @og-syn -- left a comment about the function, I think add was probably the right thing, and we should instead change the foo invocation.
Use 'add' instead of 'foo' as per review comment. I agree that 'add' conveys a meaning more readily than a generic 'foo' function.
vados-cosmonic
approved these changes
Aug 16, 2025
Collaborator
vados-cosmonic
left a comment
vados-cosmonic
left a comment
There was a problem hiding this comment.
LGTM 🚀
Appreciate the fixes @og-syn 🙇
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an example which uses 'add' but where the surrounding text uses 'foo' as a function name. Foo seems more thematic.
There's also a minor typo ('and' is misspelled AFAICT).