Revise JavaScript language support section#304
Merged
vados-cosmonic merged 8 commits intobytecodealliance:mainfrom Sep 9, 2025
Merged
Revise JavaScript language support section#304vados-cosmonic merged 8 commits intobytecodealliance:mainfrom
vados-cosmonic merged 8 commits intobytecodealliance:mainfrom
Conversation
As with other sections, added more details and factored out code examples into other files. * Fixed two errors in `jco componentize` command The world name was wrong in one of the commands, and "--disable all" should be "--disable=all" (at least with a recent jco version) * Added omitted steps of creating package.json files (without which we get "Cannot use import statement outside a module" error) * Fixed missing semicolon in component.wit file for string-reverse example * Corrected string-reverse example to use split() and join() (the example didn't run before) * Corrected string-reverse-uppercase example to declare reverseAndUppercase(s) rather than reverseAndUppercase() (this example also didn't run before).
catamorphism
force-pushed
the
language-support-js
branch
from
d8b1036 to
fb29cd0
Compare
vados-cosmonic
approved these changes
Sep 3, 2025
Collaborator
vados-cosmonic
left a comment
vados-cosmonic
left a comment
There was a problem hiding this comment.
LGTM 🚀
Thanks for working on this @catamorphism , left a few nits that should be very minor
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Co-authored-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As with other sections, added more details and factored out code examples into other files.
jco componentizecommandThe world name was wrong in one of the commands, and "--disable all"
should be "--disable=all" (at least with a recent jco version)
we get "Cannot use import statement outside a module" error)
didn't run before)
rather than reverseAndUppercase() (this example also didn't run before).