fix(core): async import emission #1455
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Ah note this isn't quite ready yet -- I want to combine this with other changes (i.e. |
vados-cosmonic
force-pushed
the
fix(core)=async-import-emission
branch
from
d1aaca2 to
23c974e
Compare
Contributor
Author
|
OK, I'm through with confirming that this change works with the latest component bindgen code used in Jco -- would appreciate a review of this PR 🙇 Going to rebase to kick off the tests once more and ensure that checks are still passing. |
This commit fixes async import emissions in the case of lowered args and lifted resutls. There were a few bugs to fix: - AsyncTaskReturn was not being emitted - Implementation for async imports was not present
vados-cosmonic
force-pushed
the
fix(core)=async-import-emission
branch
from
23c974e to
7db2cdb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes async import emissions in the case of lowered args and lifted resutls.
There were a few bugs to fix:
AsyncTaskReturn was not being emitted
Implementation for async imports was not present