Conversation
Member
Author
|
Hi @grooverdan @YoungHypo , as we discussed in #79, I submitted a separate VIDEX-server docker images PR to enable a short, end-to-end workflow (start server + sync metadata) with concise Docker commands. Could you please review? Thanks! |
c973463 to
0151cc7
Compare
grooverdan
reviewed
Jan 19, 2026
f0a43ea to
0151cc7
Compare
YoungHypo
suggested changes
Jan 28, 2026
a1b146b to
91687a5
Compare
Member
Author
|
All comments are resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
This PR introduces a combined
videx-serverDocker image that can run either the VIDEX server or thevidex-syncworkflow from the same image, removing the need to prepare a separate Python environment forvidex_build_env/videx-sync. It also adds Docker usage documentation indoc/VIDEX_SERVER_DOCKER.md.Related Issues
Related: MDEV-38422
Detailed Description
What problem does this PR solve?
Previously, the Dockerfile and documentation did not provide an easy “one-image” path for the full VIDEX flow. In practice, users had to run the server and then run
videx-sync(videx_build_env) separately, which typically required setting up a dedicated Python environment outside the container.This PR makes an end-to-end experience (start server + sync metadata) using several docker commands.
How does the solution work?
kangrongme/videx-server:0.2.0is provided (and pushed) which supports two entrypoint modes:server(default): starts the VIDEX serversync: runs the one-shotvidex-sync/videx_build_envworkflowdoc/VIDEX_SERVER_DOCKER.mdexplains:localhost) for a smoother workflowdoc/videx-storage-engine.md.Important: Before submitting, please complete the description above and review the checklist below.
Contribution Guidelines (Expand for Details)
We appreciate your contribution to VIDEX! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:
Pull Request Title Format
Your PR title should start with one of these prefixes to indicate the nature of the change:
[Core]: Changes to core engine functionality[Opt]: Changes to VIDEX-Optimizer-Plugin[Stats]: Changes to VIDEX-Statistic-Server[Algo]: Implementation of new algorithms for NDV, cardinality estimation, etc.[Pipe]: Enhancements to the pipeline (e.g., data collection, environment setup)[Bug]: Corrections to existing functionality[CI]: Changes to build process or CI pipeline[Docs]: Updates or additions to documentation[Test]: Adding or updating tests[Perf]: Performance improvements[Misc]: For changes not covered above (use sparingly)Note: For changes spanning multiple categories, use the most specific prefix or multiple prefixes in order of importance (e.g., [Algorithm][Stats]).
Submission Checklist
By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.