fix(histogram): correct scale factor calculation for cumulative frequency#87
Open
quanjnq wants to merge 1 commit intobytedance:mainfrom
Open
fix(histogram): correct scale factor calculation for cumulative frequency#87quanjnq wants to merge 1 commit intobytedance:mainfrom
quanjnq wants to merge 1 commit intobytedance:mainfrom
Conversation
|
|
quanjnq
force-pushed
the
bugfix/histogram-scale-factor
branch
from
649ffdc to
623f3bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Fixed an incorrect scale factor calculation for histogram cumulative frequency normalization.
The original formula had the numerator and denominator inverted, preventing the cumulative frequency from being properly normalized to 1.
Related Issues
Resolves: #86