Modularize for packaging and install with setuptools.#1
Open
kwarrick wants to merge 1 commit intoc01db33f:masterfrom
kwarrick:package
Open
Modularize for packaging and install with setuptools.#1kwarrick wants to merge 1 commit intoc01db33f:masterfrom kwarrick:package
kwarrick wants to merge 1 commit intoc01db33f:masterfrom
kwarrick:package
Conversation
Owner
|
Hmmmm. I don't seem to be able to actually install in a virtualenv using this; as capstone seems to be problematic, and doing naughty things. Did you have issues with that as well? I guess it needs to install the native components into system locations. |
Author
|
Ah, yes, I have a system install of capstone and then do a Also, please consider this PR a template; it is not necessarily merge-worthy. I made changes to the imports you may not favor. I can of course adjust it to your liking - just say the word. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wanted to be able to install your project into my virtualenv, so I moved the code to a
pyreildirectory, updated imports, and added asetup.py.Many thanks for this project, hope it helps.